-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursively check for last item in nested lists #3798
Conversation
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
|
Visual diff tests failed - pull request #3799 has been opened with the updated goldens. |
} | ||
return lastItem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably use do...while
. I always forget about that.
} | ||
return lastItem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, this would have only returned something if the nested list had items -- otherwise it would have fallen out of this block and returned previousElement
. I think now if nestedItems
initially has nothing in it, lastItem
won't get set to anything and the whole thing will return undefined
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
🎉 This PR is included in version 2.132.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
DE53272: List > Grid navigation not navigating properly to deeply nested list items
When looking for the previous item to focus in grid mode, the last item should be checked recursively for nested lists.